lidavidm commented on code in PR #13859:
URL: https://github.com/apache/arrow/pull/13859#discussion_r943931079
##########
cpp/examples/tutorial_examples/CMakeLists.txt:
##########
@@ -0,0 +1,20 @@
+project(MyExample)
Review Comment:
(nit, but just so that we don't forget: everything needs a license header)
##########
cpp/examples/tutorial_examples/CMakeLists.txt:
##########
@@ -0,0 +1,20 @@
+project(MyExample)
+set(CMAKE_CXX_STANDARD 11)
+set(BUILD_WARNING_LEVEL CHECKIN)
Review Comment:
FWIW, I don't think this is an actual CMake feature - if you want compiler
warnings you'll need to do more CMake config
##########
cpp/examples/tutorial_examples/arrow_example.cc:
##########
@@ -0,0 +1,90 @@
+#include <arrow/api.h>
+#include <arrow/result.h>
+#include <arrow/status.h>
+#include <arrow/table.h>
+
+#include <iostream>
+
+arrow::Status RunMain(int argc, char** argv) {
Review Comment:
Do we want an example that just demonstrates Status/Result?
##########
cpp/examples/tutorial_examples/file_access_example.cc:
##########
@@ -0,0 +1,126 @@
+#include <arrow/api.h>
+#include <arrow/csv/api.h>
+#include <parquet/arrow/reader.h>
+#include <parquet/arrow/writer.h>
+#include <arrow/io/api.h>
+#include <arrow/ipc/api.h>
+
+#include <iostream>
+
+arrow::Status gen_initial_file(){
Review Comment:
nit: naming style consistency
##########
cpp/examples/tutorial_examples/CMakeLists.txt:
##########
@@ -0,0 +1,20 @@
+project(MyExample)
+set(CMAKE_CXX_STANDARD 11)
Review Comment:
I guess we'll also want to make sure this gets built by CI, eventually (the
same way the 'minimal example' is)
##########
cpp/examples/tutorial_examples/arrow_example.cc:
##########
@@ -0,0 +1,90 @@
+#include <arrow/api.h>
+#include <arrow/result.h>
+#include <arrow/status.h>
+#include <arrow/table.h>
+
+#include <iostream>
+
+arrow::Status RunMain(int argc, char** argv) {
+
+ // Creating Arrays and Tables
+ arrow::Int8Builder int8builder;
+ int8_t days_raw[5] = {1, 12, 17, 23, 28};
Review Comment:
Thanks for writing out all the types explicitly!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
