kou commented on code in PR #13845:
URL: https://github.com/apache/arrow/pull/13845#discussion_r944061969
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -1019,12 +1019,13 @@ if(ARROW_USE_BOOST)
# Find static boost headers and libs
set(Boost_USE_STATIC_LIBS ON)
endif()
+ if(ARROW_BOOST_REQUIRE_LIBRARY)
+ set(ARROW_BOOST_COMPONENTS "COMPONENTS;system;filesystem")
+ endif()
resolve_dependency(Boost
REQUIRED_VERSION
${ARROW_BOOST_REQUIRED_VERSION}
- COMPONENTS
- system
- filesystem
+ ${ARROW_BOOST_COMPONENTS}
Review Comment:
Yes. Both approaches have the same effect.
I think that the empty `COMPONENTS` approach is easiar to read. Putting the
`COMPONENTS` keyword by a variable expansion may be a bit tricky.
If you like your approach, could you use `ARROW_BOOST_COMPONENTS_ARGS` or
something instead of `ARROW_BOOST_COMPONENTS` for the variable name? Because
the `COMPONENTS` keyword isn't a component.
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -1019,12 +1019,13 @@ if(ARROW_USE_BOOST)
# Find static boost headers and libs
set(Boost_USE_STATIC_LIBS ON)
endif()
+ if(ARROW_BOOST_REQUIRE_LIBRARY)
+ set(ARROW_BOOST_COMPONENTS "COMPONENTS;system;filesystem")
Review Comment:
Could you use normal list literal form instead of string representation form
for easy to read?
```suggestion
set(ARROW_BOOST_COMPONENTS COMPONENTS system filesystem)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
