psvri commented on code in PR #2413:
URL: https://github.com/apache/arrow-rs/pull/2413#discussion_r944138637
##########
arrow/src/array/builder/struct_builder.rs:
##########
@@ -233,6 +230,53 @@ impl StructBuilder {
let array_data = unsafe { builder.build_unchecked() };
StructArray::from(array_data)
}
+
+ /// Constructs and validates contents in the builder to ensure that
+ /// - fields and field_builders are of equal length
+ /// - the number of items in individual field_builders are equal to
self.len
+ /// - the number of null items in individual field_builders are equal to
null_count in self.null_buffer_builder.
+ fn validate_and_construct(&mut self) -> (Vec<ArrayData>, Option<Buffer>) {
+ if self.fields.len() != self.field_builders.len() {
+ panic!("Number of fields is not equal to the number of
field_builders.");
Review Comment:
I too was thinking the same. But I made my code according to issues expected
behavior. If the team needs it, I shall move this check to new function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
