Ted-Jiang commented on code in PR #2407:
URL: https://github.com/apache/arrow-rs/pull/2407#discussion_r944155581
##########
parquet/src/util/test_common/page_util.rs:
##########
@@ -166,11 +167,28 @@ impl<P: Iterator<Item = Page> + Send> PageReader for
InMemoryPageReader<P> {
}
fn peek_next_page(&mut self) -> Result<Option<PageMetadata>> {
- unimplemented!()
+ if let Some(x) = self.page_iter.peek() {
+ match x {
+ Page::DataPage { .. } => {
+ unreachable!()
Review Comment:
I found all test pages read by InMemoryPageReader are using DataPagev2.
and DataPagev1 not have the 'num_rows' info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
