[GitHub] [arrow] romainfrancois commented on pull request #8122: ARROW-9557: [R] Iterating over parquet columns is slow in R

[GitBox]

romainfrancois commented on pull request #8122:
URL: https://github.com/apache/arrow/pull/8122#issuecomment-697232130


   This returns too early, I believe this needs to be `RETURN_NOT_OK` instead 
of `return`: 
   
https://github.com/apache/arrow/blob/master/cpp/src/parquet/arrow/reader.cc#L185
   
   ```cpp
     Status BoundsCheck(const std::vector<int>& row_groups,
                        const std::vector<int>& column_indices) {
       for (int i : row_groups) {
         return BoundsCheckRowGroup(i);
       }
       for (int i : column_indices) {
         return BoundsCheckColumn(i);
       }
       return Status::OK();
     }
   ```
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org