mingmwang commented on code in PR #124:
URL: https://github.com/apache/arrow-ballista/pull/124#discussion_r945398184
##########
ballista/rust/core/proto/ballista.proto:
##########
@@ -503,6 +504,41 @@ message ColumnStats {
uint32 distinct_count = 4;
}
+message OperatorMetricsSet {
+ repeated OperatorMetric metrics = 1;
+}
+
+
+message NamedCount {
+ string name = 1;
+ uint64 value = 2;
+}
+
+message NamedGauge {
+ string name = 1;
+ uint64 value = 2;
Review Comment:
Good point. But in DataFusion metrics code base, the `Gauge` is of
`AtomicUsize`
````
/// A gauge is the simplest metrics type. It just returns a value.
/// For example, you can easily expose current memory consumption with a
gauge.
///
/// Note `clone`ing gauge update the same underlying metrics
#[derive(Debug, Clone)]
pub struct Gauge {
/// value of the metric gauge
value: std::sync::Arc<AtomicUsize>,
}
``
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
