zeroshade commented on code in PR #13868:
URL: https://github.com/apache/arrow/pull/13868#discussion_r945827399
##########
go/arrow/flight/flightsql/schema_ref/reference_schemas.go:
##########
@@ -88,7 +88,7 @@ var (
{Name: "column_size", Type: arrow.PrimitiveTypes.Int32,
Nullable: true},
{Name: "literal_prefix", Type: arrow.BinaryTypes.String,
Nullable: true},
{Name: "literal_suffix", Type: arrow.BinaryTypes.String,
Nullable: true},
- {Name: "create_params", Type:
arrow.ListOfField(arrow.Field{Name: "item", Type: arrow.BinaryTypes.String,
Nullable: false}), Nullable: true},
+ {Name: "create_params", Type:
arrow.ListOfField(arrow.Field{Name: "item", Type: arrow.BinaryTypes.String,
Nullable: false})},
Review Comment:
Yea, it appears that there's a difference between the C++ definition of the
schemas and the Java ones in the nullability, but isn't being caught by the
integration tests until I added Go to it. I'm guessing something isn't
comparing the nullability in schema comparisons?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
