tustvold commented on code in PR #2452:
URL: https://github.com/apache/arrow-rs/pull/2452#discussion_r945913530
##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -400,22 +400,46 @@ impl<T: ChunkReader + 'static>
ArrowReaderBuilder<SyncReader<T>> {
Self::new_builder(SyncReader(reader), metadata, options)
}
+ /// Build a [`ParquetRecordBatchReader`]
+ ///
+ /// Note: this will eagerly evaluate any [`RowFilter`] before returning
pub fn build(self) -> Result<ParquetRecordBatchReader> {
let reader =
FileReaderRowGroupCollection::new(Arc::new(self.input.0),
self.row_groups);
+
+ let mut filter = self.filter;
+ let mut selection = self.selection;
+
+ if let Some(filter) = filter.as_mut() {
Review Comment:
I purposefully opted to make ArrowPredicate take `&mut self`, this can be
exploited to allow for tracking of the current position - something this PR in
fact makes use of.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
