nealrichardson commented on a change in pull request #8249:
URL: https://github.com/apache/arrow/pull/8249#discussion_r493713616



##########
File path: cpp/src/arrow/filesystem/s3fs.cc
##########
@@ -99,7 +99,7 @@ using internal::OutcomeToStatus;
 using internal::ToAwsString;
 using internal::ToURLEncodedAwsString;
 
-const char* kS3DefaultRegion = "us-east-1";
+const char* kS3DefaultRegion = "";

Review comment:
       Does this need to be a special constant anymore? We don't generally do 
that for other parameters. Also, it's misleading since in practice the default 
is still us-east-1, it just comes from the SDK (right?).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to