avantgardnerio commented on PR #3153: URL: https://github.com/apache/arrow-datafusion/pull/3153#issuecomment-1215631278
> thinking github claims it has conflicts -- maybe it needs a rebase against master? Unfortunately due to the implementation of this: [xxx](https://github.com/apache/arrow-datafusion/blob/15a9a4becc4bb41262b10f1d5395fc1d026de753/datafusion/physical-expr/src/expressions/datetime.rs#L295) I think we have to wait for this: https://github.com/chronotope/chrono/pull/778 So that we can do this: ``` fn do_date_math<D>(prior: D, scalar: &ScalarValue, sign: i32) -> Result<D> where D: Datelike + Add<Duration, Output = D> + Add<Months, Output = D>, ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
