mark-rushakoff commented on pull request #8112: URL: https://github.com/apache/arrow/pull/8112#issuecomment-697819493
`go test -race` with go1.15.2 passes the entire Arrow suite. I don't understand enough about Arrow, or how influxdata/flux uses Arrow, to write a new test in the Arrow suite that fails. But I do understand enough about Go's unsafe pointers and checkptr to fix the failure. ``` $ git log -1 commit 886d87bdea78ce80e39a4b5b6fd6ca6042474c5f (HEAD, tag: apache-arrow-1.0.1) Author: Krisztián Szűcs <[email protected]> Date: Mon Aug 17 19:45:11 2020 +0200 [maven-release-plugin] prepare release apache-arrow-1.0.1 $ $GOPATH/bin/go1.15.2 test -race ./... ok github.com/apache/arrow/go/arrow 0.062s ok github.com/apache/arrow/go/arrow/array 0.193s ok github.com/apache/arrow/go/arrow/arrio 2.108s ok github.com/apache/arrow/go/arrow/bitutil 0.055s ok github.com/apache/arrow/go/arrow/csv 0.074s ok github.com/apache/arrow/go/arrow/decimal128 0.049s ok github.com/apache/arrow/go/arrow/float16 0.045s ? github.com/apache/arrow/go/arrow/internal/arrdata [no test files] ok github.com/apache/arrow/go/arrow/internal/arrjson 0.245s ok github.com/apache/arrow/go/arrow/internal/cpu 0.047s ? github.com/apache/arrow/go/arrow/internal/debug [no test files] ? github.com/apache/arrow/go/arrow/internal/flatbuf [no test files] ok github.com/apache/arrow/go/arrow/internal/testing/tools 0.041s ok github.com/apache/arrow/go/arrow/ipc 0.679s ok github.com/apache/arrow/go/arrow/ipc/cmd/arrow-cat 0.766s ok github.com/apache/arrow/go/arrow/ipc/cmd/arrow-file-to-stream 0.622s ok github.com/apache/arrow/go/arrow/ipc/cmd/arrow-json-integration-test 0.898s ok github.com/apache/arrow/go/arrow/ipc/cmd/arrow-ls 0.546s ok github.com/apache/arrow/go/arrow/ipc/cmd/arrow-stream-to-file 0.604s ok github.com/apache/arrow/go/arrow/math 0.041s ok github.com/apache/arrow/go/arrow/memory 0.038s ok github.com/apache/arrow/go/arrow/tensor 0.071s ``` Seems like changing the CI runners would be separate from this PR, wouldn't it? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
