tustvold commented on code in PR #2449: URL: https://github.com/apache/arrow-rs/pull/2449#discussion_r946089036
########## .github/workflows/integration.yml: ########## @@ -46,22 +69,47 @@ jobs: with: path: rust fetch-depth: 0 - - name: Setup Python - uses: actions/setup-python@v4 - with: - python-version: 3.8 - - name: Setup Archery - run: pip install -e dev/archery[docker] - - name: Execute Docker Build - run: archery docker run -e ARCHERY_INTEGRATION_WITH_RUST=1 conda-integration + - name: Make build directory + run: mkdir /build + - name: Build Rust + run: conda run --no-capture-output ci/scripts/rust_build.sh $PWD /build + - name: Build C++ + run: conda run --no-capture-output ci/scripts/cpp_build.sh $PWD /build + - name: Build C# + run: conda run --no-capture-output ci/scripts/csharp_build.sh $PWD /build + - name: Build Go + run: conda run --no-capture-output ci/scripts/go_build.sh $PWD + - name: Build Java + run: conda run --no-capture-output ci/scripts/java_build.sh $PWD /build + # Temporarily disable JS https://issues.apache.org/jira/browse/ARROW-17410 + # - name: Build JS + # run: conda run --no-capture-output ci/scripts/js_build.sh $PWD /build + - name: Install archery + run: conda run --no-capture-output pip install -e dev/archery + - name: Run integration tests + run: | + conda run --no-capture-output archery integration \ + --run-flight \ + --with-cpp=1 \ + --with-csharp=1 \ + --with-java=1 \ + --with-js=0 \ + --with-go=1 \ + --with-rust=1 \ + --gold-dirs=testing/data/arrow-ipc-stream/integration/0.14.1 \ + --gold-dirs=testing/data/arrow-ipc-stream/integration/0.17.1 \ + --gold-dirs=testing/data/arrow-ipc-stream/integration/1.0.0-bigendian \ + --gold-dirs=testing/data/arrow-ipc-stream/integration/1.0.0-littleendian \ + --gold-dirs=testing/data/arrow-ipc-stream/integration/2.0.0-compression \ + --gold-dirs=testing/data/arrow-ipc-stream/integration/4.0.0-shareddict Review Comment: Correct, this should be relatively straightforward to maintain, and we can always revert back should issues arise. Aside from giving more control, the CI reports will be more helpful as you can see the stage that failed, and it is significantly easier imo to understand what is going on and how to reproduce it locally. _I don't run docker on my machine, instead using podman, and so cannot run the archery docker commands_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org