kou commented on code in PR #13889:
URL: https://github.com/apache/arrow/pull/13889#discussion_r946106582
##########
java/pom.xml:
##########
@@ -887,6 +887,99 @@
</reporting>
</profile>
+ <profile>
+ <id>generate-jnicpp-dylib_so</id>
+ <properties>
+ <ARROW_DATASET>OFF</ARROW_DATASET>
+ <ARROW_GANDIVA>OFF</ARROW_GANDIVA>
+ <ARROW_ORC>OFF</ARROW_ORC>
+ </properties>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>exec-maven-plugin</artifactId>
+ <version>3.1.0</version>
+ <executions>
+ <execution>
+ <id>jnicppdir</id>
+ <phase>generate-resources</phase>
+ <goals>
+ <goal>exec</goal>
+ </goals>
+ <configuration>
+ <executable>mkdir</executable>
+ <commandlineArgs>-p java-dist
java-native-cpp</commandlineArgs>
+ <workingDirectory>../</workingDirectory>
+ </configuration>
+ </execution>
+ <execution>
+ <id>jnicppdefine</id>
+ <phase>generate-resources</phase>
+ <goals>
+ <goal>exec</goal>
+ </goals>
+ <configuration>
+ <executable>cmake</executable>
+ <commandlineArgs>
+ -DARROW_BOOST_USE_SHARED=OFF
Review Comment:
We can use `ARROW_DEPENDENCY_USE_SHARED=OFF` instead of multiple
`ARROW_*_USE_SHARED=OFF`s.
##########
java/pom.xml:
##########
@@ -887,6 +887,99 @@
</reporting>
</profile>
+ <profile>
+ <id>generate-jnicpp-dylib_so</id>
+ <properties>
+ <ARROW_DATASET>OFF</ARROW_DATASET>
+ <ARROW_GANDIVA>OFF</ARROW_GANDIVA>
+ <ARROW_ORC>OFF</ARROW_ORC>
+ </properties>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>exec-maven-plugin</artifactId>
+ <version>3.1.0</version>
+ <executions>
+ <execution>
+ <id>jnicppdir</id>
+ <phase>generate-resources</phase>
+ <goals>
+ <goal>exec</goal>
+ </goals>
+ <configuration>
+ <executable>mkdir</executable>
+ <commandlineArgs>-p java-dist
java-native-cpp</commandlineArgs>
+ <workingDirectory>../</workingDirectory>
+ </configuration>
+ </execution>
+ <execution>
+ <id>jnicppdefine</id>
+ <phase>generate-resources</phase>
+ <goals>
+ <goal>exec</goal>
+ </goals>
+ <configuration>
+ <executable>cmake</executable>
+ <commandlineArgs>
+ -DARROW_BOOST_USE_SHARED=OFF
+ -DARROW_BROTLI_USE_SHARED=OFF
+ -DARROW_BZ2_USE_SHARED=OFF
+ -DARROW_GFLAGS_USE_SHARED=OFF
+ -DARROW_GRPC_USE_SHARED=OFF
+ -DARROW_LZ4_USE_SHARED=OFF
+ -DARROW_OPENSSL_USE_SHARED=OFF
+ -DARROW_PROTOBUF_USE_SHARED=OFF
+ -DARROW_SNAPPY_USE_SHARED=OFF
+ -DARROW_THRIFT_USE_SHARED=OFF
+ -DARROW_UTF8PROC_USE_SHARED=OFF
+ -DARROW_ZSTD_USE_SHARED=OFF
+ -DARROW_JNI=ON
+ -DARROW_PARQUET=ON
+ -DARROW_FILESYSTEM=ON
+ -DARROW_DATASET=${ARROW_DATASET}
+ -DARROW_GANDIVA_JAVA=ON
+ -DARROW_GANDIVA_STATIC_LIBSTDCPP=ON
+ -DARROW_GANDIVA=${ARROW_GANDIVA}
+ -DARROW_ORC=${ARROW_ORC}
+ -DCMAKE_BUILD_TYPE=Release
+ -DCMAKE_INSTALL_LIBDIR=lib
+ -DCMAKE_INSTALL_PREFIX=../java-dist
+ -DCMAKE_UNITY_BUILD=ON
+ -Dre2_SOURCE=BUNDLED
Review Comment:
We can use `ARROW_DEPENDENCY_SOURCE=BUNDLED` instead of multiple
`*_SOURCE=BUNDLED`s.
##########
java/pom.xml:
##########
@@ -887,6 +887,99 @@
</reporting>
</profile>
+ <profile>
+ <id>generate-jnicpp-dylib_so</id>
+ <properties>
+ <ARROW_DATASET>OFF</ARROW_DATASET>
+ <ARROW_GANDIVA>OFF</ARROW_GANDIVA>
+ <ARROW_ORC>OFF</ARROW_ORC>
+ </properties>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>exec-maven-plugin</artifactId>
+ <version>3.1.0</version>
+ <executions>
+ <execution>
+ <id>jnicppdir</id>
+ <phase>generate-resources</phase>
+ <goals>
+ <goal>exec</goal>
+ </goals>
+ <configuration>
+ <executable>mkdir</executable>
+ <commandlineArgs>-p java-dist
java-native-cpp</commandlineArgs>
+ <workingDirectory>../</workingDirectory>
+ </configuration>
+ </execution>
+ <execution>
+ <id>jnicppdefine</id>
+ <phase>generate-resources</phase>
+ <goals>
+ <goal>exec</goal>
+ </goals>
+ <configuration>
+ <executable>cmake</executable>
+ <commandlineArgs>
+ -DARROW_BOOST_USE_SHARED=OFF
+ -DARROW_BROTLI_USE_SHARED=OFF
+ -DARROW_BZ2_USE_SHARED=OFF
+ -DARROW_GFLAGS_USE_SHARED=OFF
+ -DARROW_GRPC_USE_SHARED=OFF
+ -DARROW_LZ4_USE_SHARED=OFF
+ -DARROW_OPENSSL_USE_SHARED=OFF
+ -DARROW_PROTOBUF_USE_SHARED=OFF
+ -DARROW_SNAPPY_USE_SHARED=OFF
+ -DARROW_THRIFT_USE_SHARED=OFF
+ -DARROW_UTF8PROC_USE_SHARED=OFF
+ -DARROW_ZSTD_USE_SHARED=OFF
+ -DARROW_JNI=ON
+ -DARROW_PARQUET=ON
+ -DARROW_FILESYSTEM=ON
+ -DARROW_DATASET=${ARROW_DATASET}
+ -DARROW_GANDIVA_JAVA=ON
+ -DARROW_GANDIVA_STATIC_LIBSTDCPP=ON
+ -DARROW_GANDIVA=${ARROW_GANDIVA}
+ -DARROW_ORC=${ARROW_ORC}
+ -DCMAKE_BUILD_TYPE=Release
+ -DCMAKE_INSTALL_LIBDIR=lib
+ -DCMAKE_INSTALL_PREFIX=../java-dist
Review Comment:
Can we use the `arrow.c.jni.dist.dir` property instead of `../java-dist`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
