assignUser commented on code in PR #13896:
URL: https://github.com/apache/arrow/pull/13896#discussion_r946809101
##########
dev/archery/archery/docker/core.py:
##########
@@ -56,6 +50,18 @@ def _sanitize_command(cmd):
'arm64v8': 'aarch64',
}
+_arrow_root = os.environ.get(
+ 'ARROW_ROOT',
+ os.path.abspath(__file__).rsplit("/", 5)[0]
Review Comment:
The default value will only work if archery was installed with the `-e`
option and on windows `__file__` will use `\`.
It might still be a sensible default as I think installing with `-e` should
be the default for devs and we also use it in CI.
```suggestion
os.path.abspath(__file__).rsplit(os.path.sep, 5)[0]
```
##########
docker-compose.yml:
##########
@@ -489,7 +489,14 @@ services:
ulimits: *ulimits
environment:
<<: *ccache
+ ARROW_BUILD_STATIC: "OFF"
ARROW_CUDA: "ON"
+ ARROW_GANDIVA: "OFF"
Review Comment:
I assume this is to reduce build times and focus this on CUDA? 👍 Good idea!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
