ManManson commented on code in PR #13796:
URL: https://github.com/apache/arrow/pull/13796#discussion_r946819081
##########
cpp/src/arrow/filesystem/CMakeLists.txt:
##########
@@ -28,6 +28,23 @@ add_arrow_test(filesystem-test
EXTRA_LABELS
filesystem)
+if(ARROW_BUILD_BENCHMARKS AND ARROW_PARQUET)
+ add_arrow_benchmark(localfs_benchmark
+ PREFIX
+ "arrow-filesystem"
+ SOURCES
+ localfs_benchmark.cc
+ STATIC_LINK_LIBS
+ ${ARROW_BENCHMARK_LINK_LIBS}
+ Boost::filesystem
+ Boost::system)
Review Comment:
You are right, this should not be needed?
##########
cpp/src/arrow/filesystem/CMakeLists.txt:
##########
@@ -28,6 +28,23 @@ add_arrow_test(filesystem-test
EXTRA_LABELS
filesystem)
+if(ARROW_BUILD_BENCHMARKS AND ARROW_PARQUET)
+ add_arrow_benchmark(localfs_benchmark
+ PREFIX
+ "arrow-filesystem"
+ SOURCES
+ localfs_benchmark.cc
+ STATIC_LINK_LIBS
+ ${ARROW_BENCHMARK_LINK_LIBS}
+ Boost::filesystem
+ Boost::system)
Review Comment:
You are right, this should not be needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
