icexelloss commented on code in PR #13880:
URL: https://github.com/apache/arrow/pull/13880#discussion_r946907140
##########
cpp/src/arrow/compute/exec/asof_join_node.cc:
##########
@@ -37,13 +39,41 @@
namespace arrow {
namespace compute {
-// Remove this when multiple keys and/or types is supported
-typedef int32_t KeyType;
+template <typename T, typename V = typename T::value_type>
+inline typename T::const_iterator std_find(const T& container, const V& val) {
+ return std::find(container.begin(), container.end(), val);
+}
+
+template <typename T, typename V = typename T::value_type>
+inline bool std_has(const T& container, const V& val) {
+ return container.end() != std_find(container, val);
+}
+
+typedef uint64_t KeyType;
+typedef uint64_t TimeType;
Review Comment:
Maybe to rename to "OnType" and "ByType" to be consistent with the names
that are used in the AsofJoinOptions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
