pitrou commented on code in PR #13902:
URL: https://github.com/apache/arrow/pull/13902#discussion_r947249934
##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -32,6 +32,8 @@ if(NOT DEFINED ARROW_CPU_FLAG)
set(ARROW_CPU_FLAG "ppc")
elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "s390x")
set(ARROW_CPU_FLAG "s390x")
+ elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "riscv64")
+ set(ARROW_CPU_FLAG "riscv")
else()
set(ARROW_CPU_FLAG "x86")
Review Comment:
We might want to be stricter in our detection of x86 targets, e.g.
(untested):
```suggestion
elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "AMD64|X86|x86|i[3456]86")
set(ARROW_CPU_FLAG "x86")
else()
set(ARROW_CPU_FLAG "unknown")
```
(see https://stackoverflow.com/a/70498851 for possible values)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
