milesgranger opened a new pull request, #13904: URL: https://github.com/apache/arrow/pull/13904
Will fix [ARROW-17389](https://issues.apache.org/jira/browse/ARROW-17389) It appears when `PYARROW_INSTALL_TESTS=0`, setuptools would continue to add importable packages anyway: ``` ############################ # Package would be ignored # ############################ Python recognizes 'pyarrow.tests.parquet' as an importable package, but it is not listed in the `packages` configuration of setuptools. 'pyarrow.tests.parquet' has been automatically added to the distribution only because it may contain data files, but this behavior is likely to change in future versions of setuptools (and therefore is considered deprecated). Please make sure that 'pyarrow.tests.parquet' is included as a package by using the `packages` configuration field or the proper discovery methods (for example by using `find_namespace_packages(...)`/`find_namespace:` instead of `find_packages(...)`/`find:`). You can read more about "package discovery" and "data files" on setuptools documentation page. ``` Adding in an explicit `package_dir` seems to resolve the issue. Tested locally with both `bdist` and `bdist_wheel` `sdist` will still include tests, as I believe it's using `MANIFEST.in`. ``` $ PYARROW_INSTALL_TESTS=0 python setup.py bdist_wheel > output.txt $ cat output.txt | grep tests | wc -l 0 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
