liukun4515 commented on code in PR #2471:
URL: https://github.com/apache/arrow-rs/pull/2471#discussion_r947825906


##########
parquet/src/data_type.rs:
##########
@@ -36,29 +36,27 @@ use crate::util::{
 
 /// Rust representation for logical type INT96, value is backed by an array of 
`u32`.
 /// The type only takes 12 bytes, without extra padding.
-#[derive(Clone, Debug, PartialOrd, Default)]
+#[derive(Clone, Debug, PartialOrd, Default, PartialEq, Eq)]

Review Comment:
   > It should be signed little endian comparison, not sure this is what is 
actually implemented though
   
   Maybe I can read the codebase of the parquet-mr  of java-version, and answer 
this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to