tustvold commented on code in PR #2442:
URL: https://github.com/apache/arrow-rs/pull/2442#discussion_r947840742
##########
arrow/src/array/array_decimal.rs:
##########
@@ -475,8 +473,8 @@ impl<Ptr: Into<Decimal256>> FromIterator<Option<Ptr>> for
Decimal256Array {
}
}
-impl<Ptr: Borrow<Option<i128>>> FromIterator<Ptr> for Decimal128Array {
- fn from_iter<I: IntoIterator<Item = Ptr>>(iter: I) -> Self {
+impl<Ptr: Into<i128>> FromIterator<Option<Ptr>> for Decimal128Array {
Review Comment:
FWIW whilst here I wonder if we could do something similar to PrimitiveArray
which has a `NativeAdapter` to allow passing `Option<T>` or `T`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
