bkietz commented on a change in pull request #8246:
URL: https://github.com/apache/arrow/pull/8246#discussion_r494456605
##########
File path: r/src/arrow_cpp11.h
##########
@@ -157,8 +157,15 @@ struct ns {
template <typename Pointer>
Pointer r6_to_pointer(SEXP self) {
- return reinterpret_cast<Pointer>(
- R_ExternalPtrAddr(Rf_findVarInFrame(self, arrow::r::symbols::xp)));
+ void* p = R_ExternalPtrAddr(Rf_findVarInFrame(self, arrow::r::symbols::xp));
+ if (p == nullptr) {
Review comment:
I'd prefer to specify a complete mapping T to R6 class names, rather
than only listing special cases. This would be a pretty straightforward trait
structure in c++
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
