liukun4515 commented on issue #3031: URL: https://github.com/apache/arrow-datafusion/issues/3031#issuecomment-1218909474
> > The cast is added in the creation of physical expr/physical plan. > > Yes I agree > > It sounds like you are proposing moving the coercion to the logical planning phase -- while I am not opposed to doing so I do think it is likely a large change which I think we'll want to run by other maintainers. But getting a PR up to do the change is the first step In my knowledge from other database system, the generation for physical expr will not do any changes for original expr and just do transformation from logical expr to physical expr. I remember we discussed this a long time ago. But this issue is not used to do this, and just to optimize the case described in the beginning of this issue. > I do think it is worth considering special casing just the casting in the physical planner (as the physical planner is what is adding the casts in the first place) We can pull a new issue to discussion why and how to migrate the type coercion from physical parse to logical parse. What benefit we can get from the work. @alamb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
