jiacai2050 commented on code in PR #2498:
URL: https://github.com/apache/arrow-rs/pull/2498#discussion_r949129047
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -223,6 +223,11 @@ impl<W: Write> ArrowWriter<W> {
Ok(())
}
+ /// Returns the underlying writer.
+ pub fn into_inner(self) -> W {
Review Comment:
Thanks for reminding.
At first, I think caller should call `flush` before `into_inner`, but since
this method consume ownership, so it' best we call `flush` inside it just like
what `close` does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
