lidavidm commented on code in PR #13906: URL: https://github.com/apache/arrow/pull/13906#discussion_r949126301
########## java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/binder/ListBinder.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.arrow.adapter.jdbc.binder; + +import java.lang.reflect.Array; +import java.util.ArrayList; +import java.util.Arrays; + +import org.apache.arrow.vector.FieldVector; +import org.apache.arrow.vector.complex.ListVector; +import org.apache.arrow.vector.complex.impl.UnionListReader; +import org.apache.arrow.vector.util.Text; + +/** + * A column binder for list of primitive values. + */ +public class ListBinder extends BaseColumnBinder<ListVector> { + + private final UnionListReader listReader; + private final Class<?> arrayElementClass; + private final boolean isTextColumn; + + public ListBinder(ListVector vector) { + this(vector, java.sql.Types.ARRAY); + } + + /** + * Init ListBinder and determine type of data vector. + * + * @param vector corresponding data vector from arrow buffer for binding + * @param jdbcType parameter jdbc type + */ + public ListBinder(ListVector vector, int jdbcType) { + super(vector, jdbcType); + listReader = vector.getReader(); + Class<? extends FieldVector> dataVectorClass = vector.getDataVector().getClass(); + try { + arrayElementClass = dataVectorClass.getMethod("getObject", Integer.TYPE).getReturnType(); + } catch (NoSuchMethodException e) { + final String message = String.format("Issue to determine type for getObject method of data vector class %s ", + dataVectorClass.getName()); + throw new RuntimeException(message); + } + isTextColumn = arrayElementClass.isAssignableFrom(Text.class); + } + + @Override + public void bind(java.sql.PreparedStatement statement, int parameterIndex, int rowIndex)throws java.sql.SQLException { + listReader.setPosition(rowIndex); + ArrayList<?> sourceArray = (ArrayList<?>) listReader.readObject(); + Object array; + if (!isTextColumn) { + array = Array.newInstance(arrayElementClass, sourceArray.size()); + Arrays.setAll((Object[]) array, sourceArray::get); + } else { + array = new String[sourceArray.size()]; + Arrays.setAll((Object[]) array, idx -> sourceArray.get(idx) != null ? sourceArray.get(idx).toString() : null); Review Comment: nit: instead of calling `get` twice, use `sourceArray.isNull(idx)` ########## java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/JdbcParameterBinderTest.java: ########## @@ -385,6 +388,106 @@ void decimal256() throws SQLException { Arrays.asList(new BigDecimal("120.429"), new BigDecimal("-10590.123"), new BigDecimal("0.000"))); } + @Test + void listOfDouble() throws SQLException { + TriConsumer<ListVector, Integer, Double[]> setValue = (listVector, index, values) -> { + org.apache.arrow.vector.complex.impl.UnionListWriter writer = listVector.getWriter(); + writer.setPosition(index); + writer.startList(); + Arrays.stream(values).forEach(doubleValue -> writer.float8().writeFloat8(doubleValue)); + writer.endList(); + listVector.setLastSet(index); + }; + List<Double[]> values = Arrays.asList(new Double[]{0.0, Math.PI}, new Double[]{1.1, -352346.2, 2355.6}, + new Double[]{-1024.3}); + testListType(new ArrowType.FloatingPoint(FloatingPointPrecision.DOUBLE), setValue, ListVector::setNull, values); + } + + @Test + void listOfInt64() throws SQLException { + TriConsumer<ListVector, Integer, Long[]> setValue = (listVector, index, values) -> { + org.apache.arrow.vector.complex.impl.UnionListWriter writer = listVector.getWriter(); + writer.setPosition(index); + writer.startList(); + Arrays.stream(values).forEach(longValue -> writer.bigInt().writeBigInt(longValue)); + writer.endList(); + listVector.setLastSet(index); + }; + List<Long[]> values = Arrays.asList(new Long[]{1L, 2L, 3L}, new Long[]{4L, 5L}, + new Long[]{512L, 1024L, 2048L, 4096L}); + testListType((ArrowType) new ArrowType.Int(64, true), setValue, ListVector::setNull, values); + } + + @Test + void listOfInt32() throws SQLException { + TriConsumer<ListVector, Integer, Integer[]> setValue = (listVector, index, values) -> { + org.apache.arrow.vector.complex.impl.UnionListWriter writer = listVector.getWriter(); + writer.setPosition(index); + writer.startList(); + Arrays.stream(values).forEach(integerValue -> writer.integer().writeInt(integerValue)); + writer.endList(); + listVector.setLastSet(index); + }; + List<Integer[]> values = Arrays.asList(new Integer[]{1, 2, 3}, new Integer[]{4, 5}, + new Integer[]{512, 1024, 2048, 4096}); + testListType((ArrowType) new ArrowType.Int(32, true), setValue, ListVector::setNull, values); + } + + @Test + void listOfInt32WithEmptyList() throws SQLException { Review Comment: nit: why not just add an empty list value to each of the test cases, instead of having a separate test only for one case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
