andygrove commented on code in PR #35:
URL:
https://github.com/apache/arrow-datafusion-python/pull/35#discussion_r949159755
##########
src/dataframe.rs:
##########
@@ -164,4 +164,24 @@ impl PyDataFrame {
let batches = wait_for_future(py, df.collect())?;
Ok(pretty::print_batches(&batches)?)
}
+
+ /// Calculate the union of two `DataFrame`s, preserving duplicate rows.The
+ /// two `DataFrame`s must have exactly the same schema
+ #[args(distinct = false)]
+ fn union(&self, py_df: PyDataFrame, distinct: bool) -> PyResult<Self> {
Review Comment:
It seems confusing to me to have a `distinct` parameter to this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
