Luminarys opened a new pull request #8266: URL: https://github.com/apache/arrow/pull/8266
This should handle all no overflow behavior fine, but it's less clear to me what the appropriate behavior should be if overflow could occur. If we're assuming it can be UB then I believe this change is correct, otherwise some revision may be needed. Additionally I'm assuming that BasicDecimal128 will never be constructed with a value greater than the given max/min, I'm not sure how valid this assumption is and how it's enforced. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
