thisisnic commented on code in PR #247: URL: https://github.com/apache/arrow-cookbook/pull/247#discussion_r949860555
########## r/content/index.Rmd: ########## @@ -2,7 +2,9 @@ title: Apache Arrow R Cookbook params: inline_test_output: FALSE - +editor_options: + markdown: + wrap: 72 Review Comment: What's the reason for this addition? ########## r/content/index.Rmd: ########## @@ -17,32 +19,34 @@ knitr::opts_template$set(test = list( )) ``` - - # Preface  -This cookbook aims to provide a number of recipes showing how to perform common -tasks using [arrow](https://arrow.apache.org/docs/r/). This version of the -cookbook works with arrow >= 6.0.0, but in future we will maintain different -versions for the last few major R package releases. +This cookbook aims to provide a number of recipes showing how to perform +common tasks using [arrow](https://arrow.apache.org/docs/r/). This +version of the cookbook works with arrow \>= 6.0.0, but in future we +will maintain different versions for the last few major R package +releases. ## What is Arrow? -Apache Arrow is a cross-language development platform for in-memory analytics. -The arrow R package provides a low-level interface to much of the functionality -available in the C++ implementation, as well as a higher-level interface to the -compute functionality via an implementation of the [dplyr](https://dplyr.tidyverse.org/) API. +Apache Arrow is a cross-language development platform for in-memory +analytics.\ Review Comment: I think the addition of the backslash here might be a typo? ########## r/content/index.Rmd: ########## @@ -17,32 +19,34 @@ knitr::opts_template$set(test = list( )) ``` - - # Preface  -This cookbook aims to provide a number of recipes showing how to perform common -tasks using [arrow](https://arrow.apache.org/docs/r/). This version of the -cookbook works with arrow >= 6.0.0, but in future we will maintain different -versions for the last few major R package releases. +This cookbook aims to provide a number of recipes showing how to perform +common tasks using [arrow](https://arrow.apache.org/docs/r/). This +version of the cookbook works with arrow \>= 6.0.0, but in future we +will maintain different versions for the last few major R package +releases. Review Comment: I can't tell what's changed here - can you elaborate please? ########## r/content/arrays.Rmd: ########## @@ -1,3 +1,20 @@ +<!-- Licensed to the Apache Software Foundation (ASF) under one --> +<!-- or more contributor license agreements. See the NOTICE file --> +<!-- distributed with this work for additional information --> +<!-- regarding copyright ownership. The ASF licenses this file --> +<!-- to you under the Apache License, Version 2.0 (the --> +<!-- "License"); you may not use this file except in compliance --> +<!-- with the License. You may obtain a copy of the License at --> + +<!-- http://www.apache.org/licenses/LICENSE-2.0 --> + +<!-- Unless required by applicable law or agreed to in writing, --> +<!-- software distributed under the License is distributed on an --> +<!-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY --> +<!-- KIND, either express or implied. See the License for the --> +<!-- specific language governing permissions and limitations --> +<!-- under the License. --> + Review Comment: Would it work to have these as one multi-line comment instead of a lots of individual line comments? I think that would look neater. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
