alamb commented on code in PR #3185:
URL: https://github.com/apache/arrow-datafusion/pull/3185#discussion_r950062298
##########
datafusion/core/tests/provider_filter_pushdown.rs:
##########
@@ -146,7 +147,20 @@ impl TableProvider for CustomProvider {
match &filters[0] {
Expr::BinaryExpr { right, .. } => {
let int_value = match &**right {
+ Expr::Literal(ScalarValue::Int8(i)) => i.unwrap() as i64,
Review Comment:
I think you might want do avoid doing this for NULLs (aka `None`) values
Something like:
```suggestion
Expr::Literal(ScalarValue::Int8(Some(i))) => i as i64,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
