tustvold commented on issue #982: URL: https://github.com/apache/arrow-rs/issues/982#issuecomment-1220594232
https://github.com/apache/arrow-rs/pull/2481 adopts option 2, as it is consistent with how we handle overflow elsewhere, and more importantly doesn't have a runtime cost. Signed overflow in Rust is defined as twos complement, it isn't UB like it technically is in C++, and arrow-rs follows this example. I hope that is ok, I wasn't actually aware of this ticket before I implemented #2481 :sweat_smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
