amrltqt commented on issue #2361:
URL: https://github.com/apache/arrow-rs/issues/2361#issuecomment-1220857230

   I can help on this one. 
   
   Is it better to bring a full support of the builder properties through 
environment or just the minimum to leverage AWS_* regular environment setup?
   
   **Solution 1** we bring everything from environment but we need to introduce 
new  variables to match each builder properties.
    
   ```rust
   let object_store = AmazonS3Builder::from_env().build();
   
   // or even ?
   let object_store = AmazonS3::from_env();
   ```
   
   **Solution 2** we match existing AWS variable and provide support for AWS_* 
variables described 
[there](https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-envvars.html#envvars-set)
 
   
   ```rust
   let object_store = AmazonS3Builder::from_env()
       .with_bucket_name("the-bucket-name")
       .with_allow_http(true);
   ```
   
   **Solution 3** we support only the 4 variables used in integration test for 
now 
   (those ones: 
https://github.com/apache/arrow-rs/blob/master/object_store/src/aws/mod.rs#
   
   Which one is the most suitable for you? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to