kmitchener opened a new pull request, #3210:
URL: https://github.com/apache/arrow-datafusion/pull/3210
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #3057 .
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Root cause of the issue was that down one code path, creating a physical
plan wasn't setting the query_execution_start_time in session state. I've fixed
it by making the code the same between DataFrame's create_physical_plan() and
SessionContext's create_physical_plan().
I think there's good potential for cleanup of some logic in these code
paths, but I can follow up with a separate PR for that.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
now() works correctly across statements in the same session regardless of
code path taken to execute the SQL
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
