jackwener opened a new issue, #3216:
URL: https://github.com/apache/arrow-datafusion/issues/3216

   **Is your feature request related to a problem or challenge? Please describe 
what you are trying to do.**
   A clear and concise description of what the problem is. Ex. I'm always 
frustrated when [...] 
   (This section helps Arrow developers understand the context and *why* for 
this feature, in addition to  the *what*)
   
   **Describe the solution you'd like**
   
   ----------- now ------------
   Now, we put all operators in one level.
   Like following:
   
   ```rust
   pub enum Operator {
       /// Expressions are equal
       Eq,
       /// Expressions are not equal
       NotEq,
       /// Left side is smaller than right side
       Lt,
       /// Left side is smaller or equal to right side
       LtEq,
       /// Left side is greater than right side
       Gt,
       .....
   }
   ```
   ----------- want to do ------------
   
   But, in fact, operator  are different categories.
   
   we can 
   
   ```rust
   pub enum ComparisonOp {
       Eq,
       NotEq,
       Lt,
       LtEq,
       Gt,
       GtEq,
   }
   
   pub enum Operator {
       ComparisonOp(ComparisonOp),
       other ...
   }
   ```
   
   **Describe alternatives you've considered**
   A clear and concise description of any alternative solutions or features 
you've considered.
   
   **Additional context**
   
   ------- pg doc ---------
   
   Like pg expr 
[operator](https://www.postgresql.org/docs/current/functions.html)
   
   [9.2. Comparison Functions and 
Operators](https://www.postgresql.org/docs/current/functions-comparison.html)
   ....
   
   ------- project --------
   In specific project
   
   spark:
   ```scala
   case class GreaterThan(left: Expression, right: Expression)
       extends BinaryComparison 
   ```
   presto:
   ```java
   public class ComparisonExpression
           extends Expression
   {
       private final Operator operator;
       private final Expression left;
       private final Expression right;
   }
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to