lidavidm commented on code in PR #13939:
URL: https://github.com/apache/arrow/pull/13939#discussion_r951544817
##########
cpp/src/arrow/engine/CMakeLists.txt:
##########
@@ -58,7 +58,11 @@ foreach(LIB_TARGET ${ARROW_SUBSTRAIT_LIBRARIES})
target_compile_definitions(${LIB_TARGET} PRIVATE ARROW_ENGINE_EXPORTING)
endforeach()
-set(ARROW_SUBSTRAIT_TEST_LINK_LIBS ${ARROW_SUBSTRAIT_LINK_lIBS}
${ARROW_TEST_LINK_LIBS})
+if(NOT ARROW_SUBSTRAIT_LINK_LIBS)
+ set(ARROW_SUBSTRAIT_LINK_LIBS substrait)
Review Comment:
I think there's probably a missing dependency in ThirdpartyToolchain between
the generated header and the command that generates it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
