andygrove commented on code in PR #3189:
URL: https://github.com/apache/arrow-datafusion/pull/3189#discussion_r951814941
##########
datafusion/sql/src/planner.rs:
##########
@@ -1882,6 +1882,14 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
self.sql_expr_to_logical_expr(*expr, schema, ctes)?,
))),
+ SQLExpr::IsTrue(expr) => Ok(Expr::IsTrue(Box::new(
+ self.sql_expr_to_logical_expr(*expr, schema, ctes)?,
+ ))),
Review Comment:
Yes, that is related to the work I am starting in
https://github.com/apache/arrow-datafusion/pull/3222. I think we need to do
some type validation here so that if we see `<expr> IS TRUE` where `expr` is
not boolean, then we either add a cast or throw an error if it cannot be cast
to boolean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
