[GitHub] [arrow-rs] thinkharderdev commented on a diff in pull request #2552: Fix bug in page skipping

[GitBox]

thinkharderdev commented on code in PR #2552:
URL: https://github.com/apache/arrow-rs/pull/2552#discussion_r952440845


##########
parquet/src/arrow/arrow_reader/selection.rs:
##########
@@ -595,5 +595,24 @@ mod tests {
 
         // assert_eq!(mask, vec![false, true, true, false, true, true, true]);
         assert_eq!(ranges, vec![10..20, 20..30, 40..50, 50..60, 60..70]);
+
+        let selection = RowSelection::from(vec![
+            // Skip first page
+            RowSelector::skip(10),
+            // Multiple selects in same page
+            RowSelector::select(3),

Review Comment:
   Yeah, this test is actually unrelated to the fix. I originally thought the 
bug was in the `scan_ranges` so I added this test. But it turned out to be 
unrelated and I figured I might as well leave another unit test in. Sorry for 
the confusion :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org