jonkeane commented on code in PR #13878:
URL: https://github.com/apache/arrow/pull/13878#discussion_r952576218
##########
r/R/type.R:
##########
@@ -56,7 +56,9 @@ DataType$import_from_c <- ImportType
INTEGER_TYPES <- as.character(outer(c("uint", "int"), c(8, 16, 32, 64),
paste0))
FLOAT_TYPES <- c("float16", "float32", "float64", "halffloat", "float",
"double")
-#' Infer the arrow Array type from an R object
+#' Infer Arrow type
+#'
+#' Infer the Arrow Array type from an R object.
Review Comment:
> I thought that the title and description should be set separately, even if
the content is similar.
Hmm, we have a
[number](https://github.com/apache/arrow/blob/8b8914719cdfd6a18158783716562249025e9e63/r/R/schema.R#L335)
[of
other](https://github.com/apache/arrow/blob/8b8914719cdfd6a18158783716562249025e9e63/r/R/schema.R#L317)
[places](https://github.com/apache/arrow/blob/8b8914719cdfd6a18158783716562249025e9e63/r/R/dictionary.R#L67)
Where we have the pattern of title-only roxygen blocks. If we don't have
anything additional to say for the description in this block we should follow
that same pattern and simply remove the "duplicated" line, IMO. Less code |
fewer lines == less maintenance after all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
