[GitHub] [arrow-rs] jhorstmann commented on a diff in pull request #2557: Add the `length` field for Buffer and use more `Buffer` in IPC reader to avoid memory copy.

Tue, 23 Aug 2022 08:50:59 -0700 


jhorstmann commented on code in PR #2557:
URL: https://github.com/apache/arrow-rs/pull/2557#discussion_r952805666


##########
integration-testing/src/flight_server_scenarios/integration_test.rs:
##########
@@ -354,7 +355,7 @@ async fn save_uploaded_chunks(
 
                 let batch = record_batch_from_message(
                     message,
-                    &data.data_body,
+                    &Buffer::from(data.data_body),

Review Comment:
   `Buffer::from_custom_allocation` could avoid the copy.
   
   [Example / test 
case](https://github.com/apache/arrow-rs/blob/34305378ce69999444a24d1a77ad65250055a8a3/arrow/src/buffer/immutable.rs#L532)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to