tustvold commented on code in PR #2563:
URL: https://github.com/apache/arrow-rs/pull/2563#discussion_r952960823
##########
object_store/src/util.rs:
##########
@@ -101,30 +131,29 @@ where
while end_idx != ranges.len()
&& ranges[end_idx]
.start
- .checked_sub(ranges[start_idx].end)
+ .checked_sub(range_end)
Review Comment:
This was also wrong, we don't want to compare against the end of the first
range, but the maximum end that we have so far encountered
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
