rtpsw commented on PR #13880: URL: https://github.com/apache/arrow/pull/13880#issuecomment-1225741731
The last commit fixes a couple of issues: - Nullable by-key: fix for the case where batches, possibly across inputs, differ in their nullability. I opted to add an option flag for whether null by-key values are expected. Avoiding this flag, while maintaining performance in the case of non-nullable by-key values, would require dynamically rebuilding `memo_` upon detection of a switch to nullable by-key values. - Out-of-order on-key: fix to detect the case of the second row being out-of-order with respect to the first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
