lidavidm commented on code in PR #13492:
URL: https://github.com/apache/arrow/pull/13492#discussion_r953854023
##########
format/FlightSql.proto:
##########
@@ -1475,6 +1577,35 @@ message CommandStatementQuery {
// The SQL syntax.
string query = 1;
+ // Include the query as part of this transaction (if unset, the query is
auto-committed).
+ bytes transaction_id = 2;
Review Comment:
Flight SQL uses explicit optional else though (just to make it clear what is
expected), so Flight SQL actually has a higher protoc minimum version as a
result
##########
format/FlightSql.proto:
##########
@@ -1475,6 +1577,35 @@ message CommandStatementQuery {
// The SQL syntax.
string query = 1;
+ // Include the query as part of this transaction (if unset, the query is
auto-committed).
+ bytes transaction_id = 2;
Review Comment:
Flight SQL uses explicit optional elsewhere though (just to make it clear
what is expected), so Flight SQL actually has a higher protoc minimum version
as a result
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
