sunchao commented on code in PR #2566:
URL: https://github.com/apache/arrow-rs/pull/2566#discussion_r953917688
##########
arrow/src/compute/kernels/aggregate.rs:
##########
@@ -1003,4 +1035,17 @@ mod tests {
assert_eq!(Some(true), min_boolean(&a));
assert_eq!(Some(true), max_boolean(&a));
}
+
+ #[test]
+ fn test_sum_dyn() {
+ let values = Int8Array::from_iter_values([10_i8, 11, 12, 13, 14, 15,
16, 17]);
Review Comment:
it'd be nice if we have a test case for null values too, as well as all
nulls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
