westonpace commented on code in PR #13965: URL: https://github.com/apache/arrow/pull/13965#discussion_r954058647
########## cpp/src/arrow/engine/api.h: ########## @@ -19,6 +19,4 @@ #pragma once -#include "arrow/engine/substrait/extension_set.h" #include "arrow/engine/substrait/extension_types.h" -#include "arrow/engine/substrait/serde.h" Review Comment: Why remove `serde.h`? Is it transitively pulling in something internal or was this change a preference thing? This is probably the most significant public header so I'll need to figure out how we can get it in this list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
