rtpsw commented on code in PR #13880:
URL: https://github.com/apache/arrow/pull/13880#discussion_r954275317
##########
cpp/src/arrow/compute/exec/asof_join_node.cc:
##########
@@ -482,20 +706,22 @@ class CompositeReferenceTable {
class AsofJoinNode : public ExecNode {
// Advances the RHS as far as possible to be up to date for the current LHS
timestamp
- bool UpdateRhs() {
+ Result<bool> UpdateRhs() {
Review Comment:
This method can fail if `AdvanceAndMemoize` fails, which could happen if the
on-key values are unordered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
