pitrou commented on code in PR #13966:
URL: https://github.com/apache/arrow/pull/13966#discussion_r954602994
##########
dev/archery/archery/crossbow/core.py:
##########
@@ -696,7 +696,7 @@ def get_version(root, **kwargs):
# query the calculated version based on the git tags
kwargs['describe_command'] = (
- 'git describe --dirty --tags --long --match "apache-arrow-[0-9].*"'
+ 'git describe --dirty --tags --long --match "apache-arrow-[0-9]*.*"'
Review Comment:
I would mandate at least one digit
```suggestion
'git describe --dirty --tags --long --match "apache-arrow-[0-9]+.*"'
```
##########
python/setup.py:
##########
@@ -586,7 +586,7 @@ def parse_git(root, **kwargs):
"""
from setuptools_scm.git import parse
kwargs['describe_command'] =\
- 'git describe --dirty --tags --long --match "apache-arrow-[0-9].*"'
+ 'git describe --dirty --tags --long --match "apache-arrow-[0-9]*.*"'
Review Comment:
Wow, how many instances of this do we have? :-)
```suggestion
'git describe --dirty --tags --long --match "apache-arrow-[0-9]+.*"'
```
##########
python/pyarrow/__init__.py:
##########
@@ -51,7 +51,7 @@ def parse_git(root, **kwargs):
"""
from setuptools_scm.git import parse
kwargs['describe_command'] = \
- "git describe --dirty --tags --long --match
'apache-arrow-[0-9].*'"
+ "git describe --dirty --tags --long --match
'apache-arrow-[0-9]*.*'"
Review Comment:
Same here
```suggestion
"git describe --dirty --tags --long --match
'apache-arrow-[0-9]+.*'"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
