liukun4515 commented on code in PR #2586:
URL: https://github.com/apache/arrow-rs/pull/2586#discussion_r954749076
##########
arrow-flight/src/lib.rs:
##########
@@ -254,10 +254,17 @@ impl From<SchemaAsIpc<'_>> for FlightData {
}
}
-impl From<SchemaAsIpc<'_>> for SchemaResult {
- fn from(schema_ipc: SchemaAsIpc) -> Self {
- let IpcMessage(vals) = flight_schema_as_flatbuffer(schema_ipc.0,
schema_ipc.1);
- SchemaResult { schema: vals }
+impl TryFrom<SchemaAsIpc<'_>> for SchemaResult {
+ type Error = ArrowError;
+
+ fn try_from(schema_ipc: SchemaAsIpc) -> ArrowResult<Self> {
Review Comment:
> > Can we add ignore item in the .ignore file to ignore the changes for
arrow.flight.protocol.rs and arrow.flight.protocol.sql.rs?
>
> Are you suggesting we don't check in the generated code? I personally
agree with this, but I know that others prefer checking it in
I prefer not to submit this changes.
If user want to build this in their laptop, do they need to install the
protoc or other tools?
If user need to install the protoc or other tool, maybe we should submit
them.
But the diff formatting result in building environment is very annoying
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
