xudong963 commented on code in PR #3256:
URL: https://github.com/apache/arrow-datafusion/pull/3256#discussion_r954760952
##########
datafusion/core/src/physical_plan/hash_utils.rs:
##########
@@ -257,6 +258,32 @@ fn create_hashes_dictionary<K: ArrowDictionaryKeyType>(
Ok(())
}
+/// Hash the values in a list array
+fn create_hashes_list_array<T: OffsetSizeTrait>(
+ array: &ArrayRef,
+ random_state: &RandomState,
+ hashes_buffer: &mut [u64],
+) -> Result<()> {
+ let list_arr = array
+ .as_any()
+ .downcast_ref::<GenericListArray<T>>()
+ .unwrap();
+
+ let mut values: Vec<ArrayRef> = Vec::new();
Review Comment:
```suggestion
let mut values: Vec<ArrayRef> = Vec::with_capacity(list_arr.len());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
