pitrou commented on code in PR #13830: URL: https://github.com/apache/arrow/pull/13830#discussion_r954773835
########## cpp/src/arrow/dataset/file_base.h: ########## @@ -211,8 +221,12 @@ class ARROW_DS_EXPORT FileFragment : public Fragment, FileSource source_; std::shared_ptr<FileFormat> format_; - friend class FileFormat; + + // we do not want ParquetFileFragment to inherit these things. Review Comment: Er... if we do not expect inheritance, we should probably put this in a derived class? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
