romainfrancois commented on a change in pull request #8256:
URL: https://github.com/apache/arrow/pull/8256#discussion_r495128561



##########
File path: r/src/arrow_exports.h
##########
@@ -22,6 +22,7 @@
 #include "./arrow_cpp11.h"
 
 #if defined(ARROW_R_WITH_ARROW)
+#include <arrow/dataset/api.h>

Review comment:
       This was because of these classes that were not available in the fw 
header: 
   
   ```cpp
   R6_HANDLE(arrow::dataset::DirectoryPartitioning, "DirectoryPartitioning")
   R6_HANDLE(arrow::dataset::HivePartitioning, "HivePartitioning")
   ```
   
   forward declaring them seems to do the trick. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to