psvri commented on PR #2591:
URL: https://github.com/apache/arrow-rs/pull/2591#issuecomment-1227546766
A side effect of this PR resulted in some nice performance improvements as
well. Some othese range form 2-3% to about 30/50% for some use cases.
On my OCI 4 core arm machine these are the improvements I am getting
<details>
<summary>Click me</summary>
```
like_utf8 scalar equals time: [332.65 µs 332.75 µs 332.92 µs]
change: [-11.762% -11.542% -11.363%] (p = 0.00 <
0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
3 (3.00%) high mild
4 (4.00%) high severe
Benchmarking like_utf8 scalar contains: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase
target time to 10.0s, enable flat sampling, or reduce sample count to 40.
like_utf8 scalar contains
time: [1.9687 ms 1.9700 ms 1.9712 ms]
change: [-0.8125% -0.7296% -0.6506%] (p = 0.00 <
0.05)
Change within noise threshold.
like_utf8 scalar ends with
time: [333.54 µs 333.57 µs 333.60 µs]
change: [-6.2180% -6.1563% -6.0802%] (p = 0.00 <
0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
1 (1.00%) low severe
2 (2.00%) high mild
5 (5.00%) high severe
like_utf8 scalar starts with
time: [354.51 µs 354.59 µs 354.70 µs]
change: [-5.8751% -5.8337% -5.7908%] (p = 0.00 <
0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) low mild
2 (2.00%) high severe
like_utf8 scalar complex
time: [8.2678 ms 8.2691 ms 8.2704 ms]
change: [+0.3933% +0.4141% +0.4367%] (p = 0.00 <
0.05)
Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild
nlike_utf8 scalar equals
time: [359.67 µs 359.72 µs 359.76 µs]
change: [-33.604% -33.579% -33.553%] (p = 0.00 <
0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
1 (1.00%) low severe
1 (1.00%) low mild
2 (2.00%) high mild
1 (1.00%) high severe
nlike_utf8 scalar contains
time: [2.0056 ms 2.0071 ms 2.0086 ms]
change: [-9.1066% -9.0256% -8.9406%] (p = 0.00 <
0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild
nlike_utf8 scalar ends with
time: [357.22 µs 357.28 µs 357.34 µs]
change: [-35.930% -35.904% -35.861%] (p = 0.00 <
0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
1 (1.00%) low severe
5 (5.00%) high mild
1 (1.00%) high severe
nlike_utf8 scalar starts with
time: [377.53 µs 377.68 µs 377.84 µs]
change: [-33.147% -33.106% -33.066%] (p = 0.00 <
0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe
nlike_utf8 scalar complex
time: [8.3052 ms 8.3066 ms 8.3081 ms]
change: [-2.9553% -2.9313% -2.9080%] (p = 0.00 <
0.05)
Performance has improved.
ilike_utf8 scalar equals
time: [2.8657 ms 2.8660 ms 2.8663 ms]
change: [-4.2960% -4.1779% -4.0962%] (p = 0.00 <
0.05)
Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild
ilike_utf8 scalar contains
time: [4.4981 ms 4.4989 ms 4.4997 ms]
change: [-56.457% -56.444% -56.432%] (p = 0.00 <
0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high severe
ilike_utf8 scalar ends with
time: [2.9145 ms 2.9158 ms 2.9172 ms]
change: [-3.4589% -3.3895% -3.3206%] (p = 0.00 <
0.05)
Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severe
ilike_utf8 scalar starts with
time: [2.9147 ms 2.9154 ms 2.9162 ms]
change: [-4.4854% -4.4584% -4.4289%] (p = 0.00 <
0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) low mild
1 (1.00%) high mild
1 (1.00%) high severe
ilike_utf8 scalar complex
time: [10.155 ms 10.157 ms 10.158 ms]
change: [-1.9673% -1.9384% -1.9101%] (p = 0.00 <
0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild
nilike_utf8 scalar equals
time: [2.9256 ms 2.9261 ms 2.9267 ms]
change: [-2.7385% -2.7064% -2.6726%] (p = 0.00 <
0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
4 (4.00%) high mild
2 (2.00%) high severe
nilike_utf8 scalar contains
time: [4.5042 ms 4.5065 ms 4.5089 ms]
change: [-56.448% -56.424% -56.402%] (p = 0.00 <
0.05)
Performance has improved.
nilike_utf8 scalar ends with
time: [2.9386 ms 2.9390 ms 2.9394 ms]
change: [-1.3554% -1.3115% -1.2672%] (p = 0.00 <
0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe
nilike_utf8 scalar starts with
time: [2.8966 ms 2.8975 ms 2.8983 ms]
change: [-3.2629% -3.2297% -3.1958%] (p = 0.00 <
0.05)
Performance has improved.
nilike_utf8 scalar complex
time: [10.201 ms 10.202 ms 10.205 ms]
change: [-2.0189% -1.9831% -1.9477%] (p = 0.00 <
0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
