dragosmg commented on code in PR #13960:
URL: https://github.com/apache/arrow/pull/13960#discussion_r955320977
##########
r/R/dplyr-eval.R:
##########
@@ -121,3 +128,120 @@ format_expr <- function(x) {
}
head(out, 1)
}
+
+# vector of function names that do not have corresponding bindings, but we
+# shouldn't try to translate
+translation_exceptions <- c(
+ "c",
+ "$",
+ "factor",
+ # "~",
+ # "(",
+ "across",
+ ":",
+ "[",
+ "regex",
+ "fixed",
+ "list",
+ "%>%",
+ # all the types functions
+ "int8",
+ "int16",
+ "int32",
+ "int64",
+ "uint8",
+ "uint16",
+ "uint32",
+ "uint64",
+ "float16",
+ "halffloat",
+ "float32",
+ "float",
+ "float64",
+ "boolean",
+ "bool",
+ "utf8",
+ "large_utf8",
+ "binary",
+ "large_binary",
+ "fixed_size_binary",
+ "string",
+ "date32",
+ "date64",
+ "time32",
+ "time64",
+ "duration",
+ "null",
+ "timestamp",
+ "decimal",
+ "decimal128",
+ "decimal256"
+)
+
+register_user_bindings <- function(quo, .env) {
+ unknown_functions_chr <- setdiff(
+ all_funs(quo),
+ union(
+ names(.env),
+ translation_exceptions
+ )
+ )
+
+ if (length(unknown_functions_chr != 0)) {
+ # get the actual functions from the quosure's original environment or, if
+ # the call contains `::`, get the function from the namespace
+ unknown_functions <- purrr::map_if(
+ .x = unknown_functions_chr,
+ .p = ~ !grepl("::", .x),
+ .f = ~ tryCatch(as_function(.x, env = rlang::quo_get_env(quo)), error =
function(e) NULL),
+ .else = ~ asNamespace(sub(":{+}.*?$", "", .x))[[sub("^.*?:{+}", "", .x)]]
+ )
+
+ # set the original quosure environment as the parent environment for the
+ # functions
+ parent.env(.env) <- rlang::quo_get_env(quo)
Review Comment:
> Is `.env` here `nse_funcs`? If so, I think you need to copy it first (or
else every call to this will modify the parent of the environment in the R
package?)
`.env` is `f_env`, which contains `.cache$functions`, so AFAIU it should be
safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
